Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color picker minimum width #10663

Merged
1 commit merged into from Jul 15, 2021
Merged

Fix color picker minimum width #10663

1 commit merged into from Jul 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2021

Removed custom min width which caused a weird space on the right side. Corner radius and other properties should also work properly now.

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded the branch and tested it myself. This is great! Thanks!

Mind uploading a "before" and "after" pic on the thread?

@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jul 14, 2021
@ghost
Copy link
Author

ghost commented Jul 14, 2021

I can't currently build Terminal, but it should now look like the images in #10219.
Before it looked like this:
image

Notice the sharp flyout corners and the space on the right.

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 15, 2021
@ghost
Copy link

ghost commented Jul 15, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 84e30bc into microsoft:main Jul 15, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants