-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-evaluate the size of the quake window when it's summoned to a monitor #10674
Conversation
Wait no, this doesn't fix #10274 (comment). Hmm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep OK.
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…tor (#10674) ## Summary of the Pull Request When the quake window is moved to another monitor, re-evaluate it's size for that monitor. ## References * megathread: #8888 * Similar, but not the same: #10274 ## PR Checklist * [x] Closes #10182 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews. ## Validation Steps Performed Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.
🎉 Handy links: |
🎉 Handy links: |
Summary of the Pull Request
When the quake window is moved to another monitor, re-evaluate it's size for that monitor.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews.
Validation Steps Performed
Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.