-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shift the island up by 1px when maximized #10746
Conversation
For inexplicable reasons, the top row of pixels on our tabs, new tab button, and caption buttons is totally unclickable. The mouse simply refuses to interact with them. So when we're maximized, on certain monitor configurations, this results in the top row of pixels not reacting to clicks at all. To obey Fitt's Law, we're gonna hackily shift the entire island up one pixel. That will result in the top row of pixels in the window actually being the _second_ row of pixels for those buttons, which will make them clickable. It's perhaps not the right fix, but it works. After discussion, we think this is a fine fix for this. We don't think anyone's going to miss the top row of pixels on the TabView. The original bug is painful enough for the subset of users it impacts that this is an acceptable trade. Should a better fix be found, we can absolutely do that instead. Closes #7422
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentSPACEBAR UnregisterTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:microsoft/terminal.git repository
✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 🗜️ If you see a bunch of garbageIf it relates to a ... well-formed patternSee if there's a pattern that would match it. If not, try writing one and adding it to a Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines. Note that patterns can't match multiline strings. binary-ish stringPlease add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take it.
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
For inexplicable reasons, the top row of pixels on our tabs, new tab button, and caption buttons is totally unclickable. The mouse simply refuses to interact with them. So when we're maximized, on certain monitor configurations, this results in the top row of pixels not reacting to clicks at all. To obey Fitt's Law, we're gonna hackily shift the entire island up one pixel. That will result in the top row of pixels in the window actually being the _second_ row of pixels for those buttons, which will make them clickable. It's perhaps not the right fix, but it works. After discussion, we think this is a fine fix for this. We don't think anyone's going to miss the top row of pixels on the TabView. The original bug is painful enough for the subset of users it impacts that this is an acceptable trade. Should a better fix be found, we can absolutely do that instead. Closes #7422
🎉 Handy links: |
🎉 Handy links: |
Doing #10242 again. The space around the tabs was made equal in windowed mode. For maximized mode, I made the titlebar be 33px tall, to compensate for #10746. ![padding](https://user-images.githubusercontent.com/84711285/131723737-d63b015c-2134-465a-a15b-6b44538b95c5.png)
For inexplicable reasons, the top row of pixels on our tabs, new tab
button, and caption buttons is totally unclickable. The mouse simply
refuses to interact with them. So when we're maximized, on certain
monitor configurations, this results in the top row of pixels not
reacting to clicks at all.
To obey Fitt's Law, we're gonna hackily shift the entire island up one
pixel. That will result in the top row of pixels in the window actually
being the second row of pixels for those buttons, which will make them
clickable. It's perhaps not the right fix, but it works.
After discussion, we think this is a fine fix for this. We don't think
anyone's going to miss the top row of pixels on the TabView. The original
bug is painful enough for the subset of users it impacts that this is an
acceptable trade. Should a better fix be found, we can absolutely do that
instead.
Closes #7422