When there's no profile or title, invent a title from the commandline #10998
Conversation
This supports a future world where we give commandline-only invocations their own tabs. It was easier to promote the commandline to a title at the time of argument parsing, rather than later, but I am happy to change this if anyone disagrees.
|
This might be #6776 |
| { | ||
| // If there's no profile, but there IS a command line, set the tab title to the first part of the command | ||
| // This will ensure that the tab we spawn has a name (since it didn't get one from its profile!) | ||
| args.TabTitle(winrt::to_hstring(til::at(_commandline, 0))); |
There was a problem hiding this comment.
one weird thing - this does cause the cmdpal to display the title like:
which seemed weird but also ¯\_(ツ)_/¯
There was a problem hiding this comment.
Somewhat, but... it also suggests that you're allowed to change it (which is a somewhat nice side effect)
ghost
added
the
Needs-Author-Feedback
|
I don't totally disagree, but 1.11 is our last preview release where we can test changes that we might want to promote to 1.10 before October. Since Def Term profile selection is built on making these changes, I'd be worried about holding them back any longer than we already have. That includes the upcoming change to switch the profile here from defaultProfile to Base. We could go without this one, but it would make that switch weird. Putting all our breaking changes into one release is a bit compelling, admittedly. What do you think? |
ghost
removed
the
Needs-Author-Feedback
I didn't think we were doing that for 1.11. If we are, then we better get on it 😛 |
That's the PR queued up to go up after the three active ones merge 😉 |
|
Thank you. 😄 |
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT,
PankajBhojwani and
lhecker
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
It was insufficient to only promote commandline components to titles during commandline parsing, because we also have a whole complement of actions that contain NewTerminalArgs. The tests caught me out a little too late (sorry!). I decided it was better move promotion down to TerminalSettings. Fixes #6776 Re-implements #10998
|
🎉 Handy links: |
This supports a future world where we give commandline-only invocations
their own tabs. It was easier to promote the commandline to a title at
the time of argument parsing, rather than later, but I am happy to
change this if anyone disagrees.