Add the ability to quit all terminal instances #11143

Rosefield · 2021-09-04T19:19:31Z

Add the ability to quit all terminal instances. Doing this separately from the window layout saving ones to lessen the number of 1k+ line monsters I make y'all review.

References

#11083

PR Checklist

Closes Add a "Quit" action #11081
Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
Schema updated.

Detailed Description of the Pull Request / Additional comments

Warn the user before they do so to give a chance to cancel
Percolate a QuitAll event up to the monarch who then directs each peasant to clsoe.
Leave a window-layout-saving-sized hole to add that feature on top

Validation Steps Performed

quit with one window (from the monarch)
quit from the monarch with multiple windows
quit from a peasant
cancel the quit dialog

- Warn the user before they do so to give a chance to cancel - Percolate a QuitAll event up to the monarch who then directs each peasant to clsoe. - Leave a window layout saving sized hole to add that feature on top

zadjii-msft

Yep, this is how I'd do it!

zadjii-msft · 2021-09-07T17:47:49Z

src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw

@@ -469,4 +469,7 @@
  <data name="MinimizeToTrayCommandKey" xml:space="preserve">
    <value>Minimize current window to tray</value>
  </data>
+	<data name="QuitCommandKey" xml:space="preserve">


these are tabs, but I'm gonna be real, I'm the one who usually ends up reformatting this file in much worse ways

… resw files.

carlos-zamora

Just a few questions before signing off

src/cascadia/WindowsTerminal/AppHost.cpp

carlos-zamora · 2021-09-07T20:01:36Z

src/cascadia/Remoting/WindowManager.cpp

+    // - <none>
+    winrt::fire_and_forget WindowManager::RequestQuitAll()
+    {
+        auto strongThis{ get_strong() };


What's the strongThis for?

I think I just copied from the above RequestHideTrayIcon and I assumed it was there for an important reason. It can probably be removed?

Ah, found something on it: #10938 (comment)

carlos-zamora

As always, thanks for doing this! 😊

zadjii-msft · 2021-09-07T20:25:50Z

man ronpaul.gif is really getting a lot of milage this release

carlos-zamora · 2021-09-07T21:41:05Z

Ah! Don't forget to update the docs repo!

Added in microsoft/terminal#11143

leonMSFT · 2021-09-08T19:49:01Z

src/cascadia/Remoting/Monarch.cpp

+                              TraceLoggingKeyword(TIL_KEYWORD_TRACE));
+        };
+
+        _forEachPeasant(callback, onError);


Just curious, so if all windows get told to quit at roughly the same time, including the monarch, would it pose any issues if the monarch was the first to quit while all other peasants are in the middle of quitting (maybe if some peasants had more tabs and took longer to quit)?

I'm not sure. Since ultimately each of the quit actions is asynchronous (somewhere in the chain is a fire_and_forget method) it is hard to say. I imagine there might be some fighting for who becomes the monarch but I think that shouldn't matter since the other thread will continue quitting even while that happens. I haven't attempted to prove that behavior, so take what I just said with a grain of salt.

As a test I opened ~100 windows and initiated quit. All of the windows closed, but there remained a "runtime broker" process which exited a few seconds afterwards. I don't know what the "runtime broker" is or if I should be concerned that it hung around on its own for a little bit.

Edit: doesn't seem like the runtime broker always gets closed immediately, or at least it can stick around for a little while if there were a lot of windows.

Edit Edit: Maybe a bug, but it doesn't seem like it really matters and it is unrelated anyways, when opening a bunch of windows sometimes the process is named DesktopWindowXamlSource.

Edit Edit Edit: Opening a whole bunch of windows quickly can cause other problems. I managed to get memory corruption? Looks like the monarch died and a new one wasn't made, since quit/rename window/etc all fail to do anything.

@leonMSFT With further testing, I was able to sometimes get it to close every window except one, that presumably became the new monarch, so I'll need to figure out how to fix that.

…uit-action

ghost · 2021-09-09T14:02:09Z

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

## Summary of the Pull Request  ## References #11083 #11143  ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx  ## Detailed Description of the Pull Request / Additional comments While testing the save/quit features a number of issues were found that were caused by poor synchronization on the monarch, resulting in various unexpected crashes. Because this uses std collections, and I didn't see any builtin winrt multithreaded containers I went with the somewhat heavy-handed mutex approach. e.g. - #11083 (comment) - #11083 (comment) - #11143 This also makes it so that on quit peasants don't try to become the monarch, and the monarch closes their peasant last to prevent elections from happening.  ## Validation Steps Performed Create many windows (hold down ctrl-shift-n) then use the quit action from peasants/the monarch to make sure everything closes properly.

ghost · 2021-10-20T17:07:07Z

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

Rosefield added 3 commits September 4, 2021 15:15

Add the ability to quit all terminal instances

bd4a3b5

- Warn the user before they do so to give a chance to cancel - Percolate a QuitAll event up to the monarch who then directs each peasant to clsoe. - Leave a window layout saving sized hole to add that feature on top

add to schema

aa74d9f

Make sure the tests build too.

79c092d

zadjii-msft approved these changes Sep 7, 2021

View reviewed changes

tabs vs spaces teh endless debate. Maybe the editorconfig can include…

5072358

… resw files.

carlos-zamora reviewed Sep 7, 2021

View reviewed changes

Fix unfinished comment, add tracking number for todo.

d66a05c

carlos-zamora approved these changes Sep 7, 2021

View reviewed changes

ghost added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Sep 7, 2021

Rosefield added a commit to Rosefield/terminal-1 that referenced this pull request Sep 7, 2021

Add quit action

4b4a432

Added in microsoft/terminal#11143

Rosefield mentioned this pull request Sep 7, 2021

Add quit action MicrosoftDocs/terminal#406

Merged

leonMSFT reviewed Sep 8, 2021

View reviewed changes

Merge remote-tracking branch 'origin/main' into feature/gh11081-add-q…

cecf5af

…uit-action

zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 9, 2021

ghost merged commit bee6fb4 into microsoft:main Sep 9, 2021

Rosefield deleted the feature/gh11081-add-quit-action branch September 9, 2021 14:05

This was referenced Sep 9, 2021

Persist window layout cont. save multiple windows #11083

Merged

Attempt to make the monarch more thread safe. #11189

Merged

zadjii-msft mentioned this pull request Sep 13, 2021

Mysterious hang in Monarch::_getMostRecentPeasantID #11215

Closed

ghost mentioned this pull request Oct 20, 2021

Add a "Quit" action #11081

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the ability to quit all terminal instances #11143

Add the ability to quit all terminal instances #11143

Rosefield commented Sep 4, 2021 •

edited by DHowett

Loading

zadjii-msft left a comment

zadjii-msft Sep 7, 2021

carlos-zamora left a comment

carlos-zamora Sep 7, 2021

Rosefield Sep 7, 2021

carlos-zamora Sep 7, 2021

carlos-zamora left a comment

zadjii-msft commented Sep 7, 2021

carlos-zamora commented Sep 7, 2021

leonMSFT Sep 8, 2021

Rosefield Sep 8, 2021

Rosefield Sep 8, 2021 •

edited

Loading

Rosefield Sep 9, 2021

ghost commented Sep 9, 2021

ghost commented Oct 20, 2021

Add the ability to quit all terminal instances #11143

Add the ability to quit all terminal instances #11143

Conversation

Rosefield commented Sep 4, 2021 • edited by DHowett Loading

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft Sep 7, 2021

Choose a reason for hiding this comment

carlos-zamora left a comment

Choose a reason for hiding this comment

carlos-zamora Sep 7, 2021

Choose a reason for hiding this comment

Rosefield Sep 7, 2021

Choose a reason for hiding this comment

carlos-zamora Sep 7, 2021

Choose a reason for hiding this comment

carlos-zamora left a comment

Choose a reason for hiding this comment

zadjii-msft commented Sep 7, 2021

carlos-zamora commented Sep 7, 2021

leonMSFT Sep 8, 2021

Choose a reason for hiding this comment

Rosefield Sep 8, 2021

Choose a reason for hiding this comment

Rosefield Sep 8, 2021 • edited Loading

Choose a reason for hiding this comment

Rosefield Sep 9, 2021

Choose a reason for hiding this comment

ghost commented Sep 9, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Oct 20, 2021

Rosefield commented Sep 4, 2021 •

edited by DHowett

Loading

Rosefield Sep 8, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.