Properly manage teardown state in TermControl #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a few automatic event revokers and implements staged Close for TermControl's constituent components. Fixes #1198.
DHowett-MSFT
commented
Jun 11, 2019
| _swapChainPanel = nullptr; | ||
| _root = nullptr; | ||
| _connection = nullptr; | ||
| Close(); |
There was a problem hiding this comment.
I flipped this because calling the destructor manually is terrible.
zadjii-msft
reviewed
Jun 11, 2019
zadjii-msft
approved these changes
Jun 11, 2019
adiviness
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This commit introduces a few automatic event revokers and implements staged Close for TermControl's constituent components. It also fixes an issue in reading the title from a tab with no focused control.
Fixes #1198, #1188.
PR Checklist
Validation Steps Performed
I've opened and closed a number of tabs at a number of speeds, I can neither get it to crash nor get it to leak console hosts and shells and a bunch of memory.