Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable resizing the panes with the keyboard. #1207

Merged
merged 14 commits into from
Jul 10, 2019

Commits on Jun 9, 2019

  1. Configuration menu
    Copy the full SHA
    83f1a3b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Start working on resizable panes. This sorta works as you increase th…

    …e size, but doesn't resize down. I also had to remove the seperator. I think I need to have the resize event start from the top, then recurse down
    zadjii-msft committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    4840542 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Panes can now be a variable percent of their parent

      * Works for both vertical and horizontal splits
      * seperator is visible too
      * resizing the window works right
    zadjii-msft committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    aa16bc3 View commit details
    Browse the repository at this point in the history
  2. Add keybindings and code for handling resizing panes

      If you add keybindings for resizing, like so:
      ```json
                {
                    "command" : "resizePaneDown",
                    "keys" :
                    [
                        "alt+shift+down"
                    ]
                },
                {
                    "command" : "resizePaneLeft",
                    "keys" :
                    [
                        "alt+shift+left"
                    ]
                },
                {
                    "command" : "resizePaneRight",
                    "keys" :
                    [
                        "alt+shift+right"
                    ]
                },
                {
                    "command" : "resizePaneUp",
                    "keys" :
                    [
                        "alt+shift+up"
                    ]
                },
    
      ```
    
      Then you can now resize the panes, 5% at a time.
    
      We correctly traverse the tree to find the separator that's closest to the
      focused pane (depth-wise), but also the correct direction.
    zadjii-msft committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    81c1f0b View commit details
    Browse the repository at this point in the history
  3. Excessive doc commenting

    zadjii-msft committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    9d7857a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Try fixing resizing to 0

      I need the padding fix however
    zadjii-msft committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    ec2cca9 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/master' into dev/migrie/f/991-re…

    …sizable-panes
    
    # Conflicts:
    #	src/cascadia/TerminalApp/AppKeyBindings.cpp
    #	src/cascadia/TerminalApp/AppKeyBindings.h
    #	src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp
    zadjii-msft committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    356d3bf View commit details
    Browse the repository at this point in the history
  3. This fixes resizing two panes, but not n panes

      But that might always have been broken
    zadjii-msft committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    770cf96 View commit details
    Browse the repository at this point in the history
  4. Prevent a kinetic dissasembly during resize

      Also add comments
    zadjii-msft committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    c101054 View commit details
    Browse the repository at this point in the history
  5. runformat

    zadjii-msft committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    a365503 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2019

  1. Configuration menu
    Copy the full SHA
    0655849 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/f/991-re…

    …sizable-panes
    
    # Conflicts:
    #	src/cascadia/TerminalApp/App.cpp
    zadjii-msft committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    d65f551 View commit details
    Browse the repository at this point in the history
  2. Pr Feedback

    zadjii-msft committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    11a150a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/f/991-re…

    …sizable-panes
    
    # Conflicts:
    #	src/cascadia/TerminalApp/App.cpp
    zadjii-msft committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    4e9db7b View commit details
    Browse the repository at this point in the history