Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Opacity in Windows 10, again #12255

Merged
2 commits merged into from
Jan 26, 2022
Merged

Commits on Jan 25, 2022

  1. Fix Opacity in Windows 10, again

    More fallout from the settings refactor. Probably because testing on a Windows
    10 device is hard, because you actually need a physical machine to get acrylic
    to behave correctly.
    
    Basically, the code is simpler now, but we missed the windows 10 only edge case
    where acrylic can get turned on, but we forget to enable the acrylic brush, so
    it just stays off.
    
    Refer to #11619 where this regressed, and #11643, #12229, because this is just a
    hard problem apparently
    
    * [x] Closes #11743. Technically OP is complaining about behavior that's
      by-design, but it made me realize this regressed in 1.12.
    * [ ] No tests on this part of the TermControl unfortunately.
    * [x] Hauled out my old Win10 laptop to verify that opacity works right:
      - [x] A fresh profile isn't created with any opacity
      - [x] Mouse wheeling turns on acrylic
      - [x] Using `opacity` only in the settings still stealthily enables acrylic
    zadjii-msft committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    4779fdc View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Configuration menu
    Copy the full SHA
    9c77b1c View commit details
    Browse the repository at this point in the history