Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ever allow ~ as a startingDirectory #12437

Merged
3 commits merged into from
Feb 9, 2022
Merged

Don't ever allow ~ as a startingDirectory #12437

3 commits merged into from
Feb 9, 2022
+32 −1

Commits on Feb 8, 2022

  1. Don't ever allow ~ as a startingDirectory 

    Basically, some WSL distros ship fragments that replace the commandline with the executable for their distro (`ubuntu.exe`, etc.). We didn't exxpect that.

Unfortunately, `~` is really never a valid path for a process on windows, so those distros would now fail with

```
[error 2147942667 (0x8007010b) when launching `ubuntu1804.exe']
Could not access starting directory "~"
```

* [x] Closes #12353
* [x] Tested with a (`ubuntu1804.exe`, `~`) profile - launched successfully, where 1.13 in market fails.
    @zadjii-msft
    zadjii-msft committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    015084f View commit details
    Browse the repository at this point in the history

  2. tis was unused

    @zadjii-msft
    zadjii-msft committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    cb8b22a View commit details
    Browse the repository at this point in the history

  3. Update src/types/utils.cpp

    @DHowett
    DHowett authored Feb 8, 2022
    Configuration menu
    Copy the full SHA
    baedfe7 View commit details
    Browse the repository at this point in the history