Fix activation context generation for conhost #12653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Mar 9, 2022
DHowett
added
Work-Item
lhecker
added
Issue-Bug
zadjii-msft
approved these changes
Mar 10, 2022
zadjii-msft
added
zPreview-Service-Queued-1.13
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Mar 10, 2022
This regressed in 2b202ce, which removed `ACTCTX_FLAG_RESOURCE_NAME_VALID` during `CreateActCtxW` under the assumption that an executable only has one manifest. conhost has two however and we need to pick the correct one. On OpenConsole this causes the expected `ERROR_SXS_PROCESS_DEFAULT_ALREADY_SET`. Closes MSFT:38355907 (cherry picked from commit c820af4)
DHowett
pushed a commit
that referenced
this pull request
Mar 24, 2022
This regressed in 2b202ce, which removed `ACTCTX_FLAG_RESOURCE_NAME_VALID` during `CreateActCtxW` under the assumption that an executable only has one manifest. conhost has two however and we need to pick the correct one. On OpenConsole this causes the expected `ERROR_SXS_PROCESS_DEFAULT_ALREADY_SET`. Closes MSFT:38355907 (cherry picked from commit c820af4)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in 2b202ce, which removed
ACTCTX_FLAG_RESOURCE_NAME_VALIDduring
CreateActCtxWunder the assumption that an executable only hasone manifest. conhost has two however and we need to pick the correct one.
On OpenConsole this causes the expected
ERROR_SXS_PROCESS_DEFAULT_ALREADY_SET.Closes MSFT:38355907