Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reflow the alt buffer on resize #12719

Merged
55 commits merged into from
Apr 15, 2022
Merged

Don't reflow the alt buffer on resize #12719

55 commits merged into from
Apr 15, 2022

Commits on Feb 23, 2022

  1. I think this is the conhost half of the changes

    @zadjii-msft
    zadjii-msft committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    83466a4 View commit details
    Browse the repository at this point in the history

  2. This quite nearly implements everything for the Terminal half 

      Resizing is surely boned but this is 1000% percent better than nothing at all.
    @zadjii-msft
    zadjii-msft committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    e94e08c View commit details
    Browse the repository at this point in the history

  3. Most of the remaining todos, comments

    @zadjii-msft
    zadjii-msft committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    dd702c7 View commit details
    Browse the repository at this point in the history

  4. one last comment

    @zadjii-msft
    zadjii-msft committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    1209fa4 View commit details
    Browse the repository at this point in the history

  5. more comments are always good

    @zadjii-msft
    zadjii-msft committed Feb 23, 2022
    1 Configuration menu
    Copy the full SHA
    bf24cdd View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. spel

    @zadjii-msft
    zadjii-msft committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    dff1b94 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @zadjii-msft
    zadjii-msft committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    60d2c2e View commit details
    Browse the repository at this point in the history

  3. I think this does the whole thing

    @zadjii-msft
    zadjii-msft committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    57280d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. defer main buffer resizes till we exit, to try and prevent flashing i… 

    …n conpty. That didn't work, unfortunately
    @zadjii-msft
    zadjii-msft committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    d08d216 View commit details
    Browse the repository at this point in the history

  2. deferred resizing both in the Terminal and the ConPTY

    @zadjii-msft
    zadjii-msft committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    6529579 View commit details
    Browse the repository at this point in the history

  3. comments mostly

    @zadjii-msft
    zadjii-msft committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    5d8c0d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Stashing this for now. I think this does the save/restore cursor stuf… 

    …f that we're supposed to do when entering/exiting the alt buffer
    @zadjii-msft
    zadjii-msft committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    54dc304 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. start writing tests

    @zadjii-msft
    zadjii-msft committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    57094b7 View commit details
    Browse the repository at this point in the history

  2. make this test way more elaborate

    @zadjii-msft
    zadjii-msft committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    69d0973 View commit details
    Browse the repository at this point in the history

  3. I thought this was a test for #12561 (comment), but I think that "jus… 

    …t worked" because conpty magic.
    @zadjii-msft
    zadjii-msft committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    0a1ed70 View commit details
    Browse the repository at this point in the history

  4. More test cleanup. Make sure viewport doesnt move

    @zadjii-msft
    zadjii-msft committed Mar 8, 2022
    1 Configuration menu
    Copy the full SHA
    9453aa5 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into dev/migrie/b/alt-buff… 

    …er-terminal
    @zadjii-msft
    zadjii-msft committed Mar 8, 2022
    1 Configuration menu
    Copy the full SHA
    e658431 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev/migrie/b/alt-buffer-terminal' into dev/migrie/b/349… 

    …3-no-wrap-alt-buffer
    @zadjii-msft
    zadjii-msft committed Mar 8, 2022
    1 Configuration menu
    Copy the full SHA
    4c96fc0 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/b/alt-buff… 

    …er-terminal
    @zadjii-msft
    zadjii-msft committed Mar 16, 2022
    1 Configuration menu
    Copy the full SHA
    0cfb463 View commit details
    Browse the repository at this point in the history

  2. fine that's not a word

    @zadjii-msft
    zadjii-msft committed Mar 16, 2022
    1 Configuration menu
    Copy the full SHA
    bf3d79e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. thats not a word either

    @zadjii-msft
    zadjii-msft committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    7237fce View commit details
    Browse the repository at this point in the history

  2. notes from j4james

    @zadjii-msft
    zadjii-msft committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    65b4571 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev/migrie/b/alt-buffer-terminal' into dev/migrie/b/349… 

    …3-no-wrap-alt-buffer
    @zadjii-msft
    zadjii-msft committed Mar 17, 2022
    1 Configuration menu
    Copy the full SHA
    c8f0a5e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. cleanup

    @zadjii-msft
    zadjii-msft committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    0163878 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/b/alt-buff… 

    …er-terminal
    @zadjii-msft
    zadjii-msft committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    7c3e808 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/migrie/b/alt-buffer-terminal' into dev/migrie/b/349… 

    …3-no-wrap-alt-buffer
    @zadjii-msft
    zadjii-msft committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    324aa2d View commit details
    Browse the repository at this point in the history

  3. Adds a test for #12719 (comment)

    @zadjii-msft
    zadjii-msft committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    9eb0658 View commit details
    Browse the repository at this point in the history

  4. well that explains why I never saw this :P

    @zadjii-msft
    zadjii-msft committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    3b1ced3 View commit details
    Browse the repository at this point in the history

  5. this is barking up the wrong tree

    @zadjii-msft
    zadjii-msft committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    0e711c0 View commit details
    Browse the repository at this point in the history

  6. Revert "this is barking up the wrong tree" 

    This reverts commit 0e711c0.
    @zadjii-msft
    zadjii-msft committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    31f9904 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Add oneline test case to comments

    @zadjii-msft
    zadjii-msft committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    0ad1478 View commit details
    Browse the repository at this point in the history

  2. Just entirely revert the main buffer deferred resizing. This shows th… 

    …at this never worked in conhost
    @zadjii-msft
    zadjii-msft committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    48d47f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Revert "Just entirely revert the main buffer deferred resizing. This … 

    …shows that this never worked in conhost"

This reverts commit 48d47f8.
    @zadjii-msft
    zadjii-msft committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d7bce5a View commit details
    Browse the repository at this point in the history

  2. Hey look this worked 

    (cherry picked from commit 8ac68f2a69c708a25a8d7691846664bdf4589486)
    @zadjii-msft
    zadjii-msft committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2285ea5 View commit details
    Browse the repository at this point in the history

  3. more tests

    @zadjii-msft
    zadjii-msft committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0e8a917 View commit details
    Browse the repository at this point in the history

  4. add a helper to do this all in one place

    @zadjii-msft
    zadjii-msft committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    764237c View commit details
    Browse the repository at this point in the history

  5. A test that repros the crash

    @zadjii-msft
    zadjii-msft committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    3a52eab View commit details
    Browse the repository at this point in the history

  6. Fix underlying bug in AltBufferResizeCrash

    @lhecker
    lhecker committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    4c1404d View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. notes

    @zadjii-msft
    zadjii-msft committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    4a05760 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/b/alt-buff… 

    …er-terminal
    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    002fbbc View commit details
    Browse the repository at this point in the history

  2. fix the urls in the alt buffer

    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    f209d98 View commit details
    Browse the repository at this point in the history

  3. Merge commit 'f209d98e4310d8df57ca5b0d4e36700a140ba0bd' into dev/migr… 

    …ie/b/3493-no-wrap-alt-buffer
    @DHowett
    DHowett committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    66fa2dc View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into HEAD

    @DHowett
    DHowett committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    554fb8f View commit details
    Browse the repository at this point in the history

  5. Merge commit '554fb8f4a' into dev/migrie/b/3493-no-wrap-alt-buffer

    @DHowett
    DHowett committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    2a9eae3 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. runformat on the merge

    @zadjii-msft
    zadjii-msft committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    f2677bd View commit details
    Browse the repository at this point in the history

  2. all together, these tests can pollute each other now

    @zadjii-msft
    zadjii-msft committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    098f6e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/b/3493-no-… 

    …wrap-alt-buffer
    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    e14bba4 View commit details
    Browse the repository at this point in the history

  2. POC: You can test the input sent to the connection

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    6b89642 View commit details
    Browse the repository at this point in the history

  3. better, better, alright lets do this

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    bea906d View commit details
    Browse the repository at this point in the history

  4. this is what you call test-driven-development

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    fe35515 View commit details
    Browse the repository at this point in the history

  5. this is the real test now

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f6da747 View commit details
    Browse the repository at this point in the history

  6. tests work, which will make Dustin very happy

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    3360201 View commit details
    Browse the repository at this point in the history

  7. as discussed with dustin

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    1 Configuration menu
    Copy the full SHA
    23c6bf8 View commit details
    Browse the repository at this point in the history

  8. I actually had the wrong issue numbers

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    1 Configuration menu
    Copy the full SHA
    d157184 View commit details
    Browse the repository at this point in the history

  9. it wouldn't be a mike PR without x86 breaks and spel check

    @zadjii-msft
    zadjii-msft committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    93dbb9e View commit details
    Browse the repository at this point in the history