Fix _isDefTermSession not propagating upon pane split/close #13649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
requested changes
Aug 1, 2022
ghost
added
Needs-Author-Feedback
PankajBhojwani
changed the title
carlos-zamora
approved these changes
Aug 2, 2022
zadjii-msft
approved these changes
Aug 2, 2022
carlos-zamora
added a commit
that referenced
this pull request
Aug 2, 2022
lhecker
approved these changes
Aug 3, 2022
carlos-zamora
added a commit
that referenced
this pull request
Aug 3, 2022
DHowett
approved these changes
Aug 4, 2022
|
Thanks for this! |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Aug 8, 2022
## Summary of the Pull Request In #13560 we added a member to `Pane` that lets it know if it was spawned as a default terminal session, but did not propagate that value when the pane gets split or when the pane closes. This commit fixes that. ## Validation Steps Performed A session spawned by a def term invocation remembers it even as it goes through splits (cherry picked from commit 1a77834) Service-Card-Id: 84836635 Service-Version: 1.15
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In #13560 we added a member to
Panethat lets it know if it was spawned as a default terminal session, but did not propagate that value when the pane gets split or when the pane closes. This commit fixes that.Validation Steps Performed
A session spawned by a def term invocation remembers it even as it goes through splits