Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make about dialog content copyable #1452

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

Summon528
Copy link
Contributor

Summary of the Pull Request

Make about dialog content copyable

References

PR Checklist

  • Closes About dialog should have a copy button #1335
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Wrap aboutText with a selectable text block.

Validation Steps Performed

Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks!

Clever use of the IInspectable parameter. 😄

@DHowett-MSFT
Copy link
Contributor

It's a ContentDialog whose Content is a boxed HSTRING. This makes it the TextBlock you're suggesting we set IsTextSelectionEnabled on.

@DHowett-MSFT
Copy link
Contributor

(Terminal doesn't use .xaml files, which is something we know we need to fix, etc.)

@mdtauk
Copy link

mdtauk commented Jun 23, 2019

It's a ContentDialog whose Content is a boxed HSTRING. This makes it the TextBlock you're suggesting we set IsTextSelectionEnabled on.

I asked the question, checked the code change, and saw the property being used. Can't normally understand C++ code, so I spoke before checking lol

(Terminal doesn't use .xaml files, which is something we know we need to fix, etc.)

Xaml Direct?

@DHowett-MSFT DHowett-MSFT merged commit 0fba910 into microsoft:master Jun 24, 2019
DHowett-MSFT pushed a commit that referenced this pull request Jul 2, 2019
DHowett-MSFT pushed a commit that referenced this pull request Jul 2, 2019
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 2, 2019
@Summon528 Summon528 deleted the about-select branch July 4, 2019 09:47
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About dialog should have a copy button
4 participants