Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUI] Polish Launch Parameters setting controls #14569

Merged
3 commits merged into from
Dec 16, 2022
Merged

[SUI] Polish Launch Parameters setting controls #14569

3 commits merged into from
Dec 16, 2022

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Dec 15, 2022 •
edited
Loading

Summary of the Pull Request

Performs some cleanup in the Settings UI for the Launch Parameters settings:

  1. Updates all NumberBox controls in the Settings UI to have a Compact SpinButtonPlacementMode instead of an inline one. This alleviates the XAML bug where the spin button would appear over the number box's input value.
  2. Fixes an issue where a long X/Y value would resize the settings controls weirdly. This was fixed by introducing a Grid inside the main grid and applying a width to the number boxes.
  3. Rename "Use system default" checkbox to be more clear. Propagate the new localized string into expander preview.

Closes #14558

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Dec 15, 2022
@carlos-zamora
Copy link
Member Author

carlos-zamora commented Dec 15, 2022 •
edited
Loading

Launch Params Fix

EDIT: I'm too lazy to recapture this gif, but we've now renamed the checkbox string

@carlos-zamora carlos-zamora mentioned this pull request Dec 15, 2022
Closed
@zadjii-msft
Copy link
Member

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

@carlos-zamora
Copy link
Member Author

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

Ask and you shall receive:
image

Tested with resizing the window too. Nothing gets cropped.

@DHowett
Copy link
Member

DHowett commented Dec 15, 2022

"let system position window, centered" is a funny juxtaposition. In that specific case, it means "Let system select which monitor" (but we should phrase it better...)

lhecker
lhecker approved these changes Dec 16, 2022
View reviewed changes
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw Outdated
@@ -356,8 +356,8 @@
<comment>The string to be displayed when there is no current value in the y-coordinate number box.</comment>
</data>
<data name="Globals_DefaultLaunchPositionCheckbox.Content" xml:space="preserve">
<value>Use system default</value>
<comment>A checkbox for the "launch position" setting. Toggling this control sets the launch position to the system default.</comment>
<value>Let system position window</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since system == Windows, isn't this like "Let Windows position window"? 😄
I wonder if something like "Let Windows decide" would be better. We already use such a label for "DefaultWindowsConsoleName" after all...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% down for "Let Windows decide"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I chose "let system position window" because:

image

This is okay as well :)

@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Dec 16, 2022
@carlos-zamora
Copy link
Member Author

@msftbot merge this in 10 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 16, 2022
@ghost
Copy link

ghost commented Dec 16, 2022

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 16 Dec 2022 20:58:21 GMT, which is in 10 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit a3c7bc3 into main Dec 16, 2022
@ghost ghost deleted the dev/cazamor/launch-params-cleanup branch December 16, 2022 21:00
@ghost ghost removed the Needs-Second It's a PR that needs another sign-off label Dec 16, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@DHowett DHowett Awaiting requested review from DHowett

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.17] Launch Params in SUI needs a little cleanup
5 participants
@carlos-zamora @zadjii-msft @DHowett @lhecker @PankajBhojwani