Remove TerminalTrySetDarkTheme, use the DWMWA directly #15667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DWMWA for this has been documented for quite a while now!
zadjii-msft
approved these changes
Jul 6, 2023
lhecker
approved these changes
Jul 6, 2023
tusharsnx
pushed a commit
to tusharsnx/terminal
that referenced
this pull request
Jul 12, 2023
The DWMWA for this has been documented for quite a while now! I've also updated to a version of TerminalThemeHelpers that removes all the Dark Theme exports.
DHowett
added a commit
that referenced
this pull request
Aug 2, 2023
The DWMWA for this has been documented for quite a while now! I've also updated to a version of TerminalThemeHelpers that removes all the Dark Theme exports. (cherry picked from commit 2f0d3dc) Service-Card-Id: 90068185 Service-Version: 1.17
DHowett
added a commit
that referenced
this pull request
Aug 11, 2023
The DWMWA for this has been documented for quite a while now! I've also updated to a version of TerminalThemeHelpers that removes all the Dark Theme exports. (cherry picked from commit 2f0d3dc) Service-Card-Id: 90068186 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DWMWA for this has been documented for quite a while now!
I've also updated to a version of TerminalThemeHelpers that removes all the Dark Theme exports.