Clean up WriteConsoleInputA conversion #15672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
lhecker
changed the title
lhecker
force-pushed
the
dev/lhecker/8000-WriteConsoleInputA
branch
from
80fcebc
to
42ac9b7
Compare
DHowett
reviewed
Jul 12, 2023
Comment on lines
+166
to
+167
| lead.Event.KeyEvent.uChar.AsciiChar, | ||
| trail.Event.KeyEvent.uChar.AsciiChar, |
There was a problem hiding this comment.
hey wait a minute, won't this only work for things that take up 2 code units? a UTF-8 string can be up to 4 😉
There was a problem hiding this comment.
Yep, it works just as bad as it did before! Well... Sort of. At least it now checks if the trailing event is an actual KEY_EVENT instead of blindly casting it to a KeyEvent struct. 😅
I'm hoping to move this entire block of code into InputBuffer at a later time and come up with a proper caching system.
DHowett
reviewed
Jul 12, 2023
zadjii-msft
approved these changes
Jul 18, 2023
|
@DHowett If you get a chance would you mind reviewing this again? |
DHowett
approved these changes
Jul 18, 2023
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/lhecker/8000-WriteConsoleInputA
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit inlines
EventsToUnicodeintoWriteConsoleInputAImplbecause soon we'll not use deques for events anymore and so the old
code won't work. It cleans up the implementation because I intend to
move all this code directly into
InputBufferto have a better andtighter control over how text gets converted. UTF-8 input for instance
requires the storage of up to 3 input events and this code is not fit
to handle that. It's also unmaintainable because our input handling
code shouldn't be spread over a dozen files either. 😄
Validation Steps Performed