Remove the FontSizeChanged event from TermControl #15867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
DHowett
approved these changes
Aug 22, 2023
| @@ -947,7 +946,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| } | |||
|
|
|||
| const auto actualNewSize = _actualFont.GetSize(); | |||
| _FontSizeChangedHandlers(actualNewSize.width, actualNewSize.height, initialUpdate); | |||
| _FontSizeChangedHandlers(*this, *winrt::make_self<FontSizeChangedArgs>(actualNewSize.width, actualNewSize.height)); | |||
There was a problem hiding this comment.
*make_self<T>() is equivalent to make<T> when T's default interface is the same as the one you're converting to.
For new code, we should prefer the clearer one :)
There was a problem hiding this comment.
I forgot that make works even on a non projected ctor
carlos-zamora
approved these changes
Aug 23, 2023
DHowett
approved these changes
Aug 23, 2023
|
I pushed a merge so that it would kick the CI |
DHowett
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally just wanted to close #1104, but then discovered that hey, this event wasn't even used anymore. Excerpts of Teams convo:
pane->Relayoutwhich I don't even REMEMBERFrom Misc pane refactoring by Rosefield · Pull Request #11373 · microsoft/terminal
So, great. We can kill part of it, and convert the rest to a
TypedEvent, and get rid ofDECLARE_/DEFINE_.ScrollPositionChangedEventArgswas ALSO apparently already promoted to a typed event, so kill that too.