Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't end the current mark, if we get one of the same kind #16107

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

zadjii-msft
Copy link
Member

If you're already in the "output" state, then an app requesting an "output" mark probably shouldn't end the current mark and start a new one. It should just keep on keepin' on.

The decision to end the previous one was arbitrary in the first place, so let's arbitrarily change it back.

Especially noticable if you hit Enter during a command, because the auto-mark prompt work will do a CommandEnd, so long-running commands will get broken into multiple marks 🥲

If you're already in the "output" state, then an app requesting an "output" mark
probably shouldn't end the current mark and start a new one. It should just keep
on keepin' on.

The decision to end the previous one was arbitrary in the first place, so let's
arbitrarily change it back.

Especially noticable if you hit <kbd>Enter</kbd> during a command, because the
auto-mark prompt work will do a CommandEnd, so long-running commands will get
broken into multiple marks 🥲
@zadjii-msft zadjii-msft merged commit 0144cdd into main Oct 11, 2023
17 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/b/reentrant-marks branch October 11, 2023 16:40
DHowett pushed a commit that referenced this pull request Jan 29, 2024
If you're already in the "output" state, then an app requesting an
"output" mark probably shouldn't end the current mark and start a new
one. It should just keep on keepin' on.

The decision to end the previous one was arbitrary in the first place,
so let's arbitrarily change it back.

Especially noticable if you hit <kbd>Enter</kbd> during a command,
because the auto-mark prompt work will do a CommandEnd, so long-running
commands will get broken into multiple marks 🥲

(cherry picked from commit 0144cdd)
Service-Card-Id: 91707294
Service-Version: 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants