Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the system menu when we refrigerate a window #16225

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

zadjii-msft
Copy link
Member

As in the title. Also fixes a crash for refrigeration with the rainbow border. Closes #16211

Tested by manually forcing us into Windows 10 mode (to refrigerate the window). That immediately repros the bug, which was simple enough to fix.

As in the title. Also fixes a crash for refrigeration with the rainbow border.
Closes #16211

Tested by manually forcing us into Windows 10 mode (to refrigerate the window).
That immediately repros the bugn, which was simple enough to fix.
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Windowing Window frame, quake mode, tearout Product-Terminal The new Windows Terminal. labels Oct 24, 2023
@DHowett
Copy link
Member

DHowett commented Oct 24, 2023

Whoops!

@DHowett DHowett merged commit d8c7719 into main Oct 24, 2023
17 checks passed
@DHowett DHowett deleted the dev/migrie/b/refrigeration-bugs-0 branch October 24, 2023 18:29
DHowett pushed a commit that referenced this pull request Oct 26, 2023
As in the title. Also fixes a crash for refrigeration with the rainbow
border.

Closes #16211

Tested by manually forcing us into Windows 10 mode (to refrigerate the
window). That immediately repros the bug, which was simple enough to
fix.

(cherry picked from commit d8c7719)
Service-Card-Id: 90928408
Service-Version: 1.19
DHowett pushed a commit that referenced this pull request Nov 7, 2023
As in the title. Also fixes a crash for refrigeration with the rainbow
border.

Closes #16211

Tested by manually forcing us into Windows 10 mode (to refrigerate the
window). That immediately repros the bug, which was simple enough to
fix.

(cherry picked from commit d8c7719)
Service-Card-Id: 90928407
Service-Version: 1.18
DHowett pushed a commit that referenced this pull request Nov 7, 2023
As in the title. Also fixes a crash for refrigeration with the rainbow
border.

Closes #16211

Tested by manually forcing us into Windows 10 mode (to refrigerate the
window). That immediately repros the bug, which was simple enough to
fix.

(cherry picked from commit d8c7719)
Service-Card-Id: 90928407
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

Multiple 'Settings' entries on title bar context menu. Crashes Terminal.
3 participants