Fix scroll-forward-disable setting #16411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
DHowett
approved these changes
Dec 4, 2023
zadjii-msft
approved these changes
Dec 4, 2023
lhecker
added
the
AutoMerge
DHowett
pushed a commit
that referenced
this pull request
Dec 4, 2023
The final parameter, `updateBottom`, controls not just whether the `_virtualBottom` is updated, but also whether the position is clamped to be within the existing `_virtualBottom`. Setting this to `false` thus broke scroll-forward as the `_virtualBottom` was now a constant. ## Validation Steps Performed * Disable scroll-foward * Press and hold Ctrl+C * It scrolls past the viewport bottom ✅ (cherry picked from commit ab7a2f1) Service-Card-Id: 91258882 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final parameter,
updateBottom, controls not just whether the_virtualBottomis updated, but also whether the position is clampedto be within the existing
_virtualBottom. Setting this tofalsethus broke scroll-forward as the
_virtualBottomwas now a constant.Validation Steps Performed