Fix conhost clipboard handling bugs #16457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
|
@DHowett This is another PR we could merge into 1.19 inbox if we wanted to. It does fix actual bugs, but they have been in conhost since forever and so I'm not sure how important fixing it ASAP is. |
lhecker
force-pushed
the
dev/lhecker/fix-clipboard-bugs
branch
from
cb8ad8e
to
44383a0
Compare
DHowett
requested changes
Dec 12, 2023
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
zadjii-msft
approved these changes
Jan 29, 2024
DHowett
approved these changes
Jan 29, 2024
|
@lhecker merge conflict from Tushar's work |
lhecker
commented
Jan 29, 2024
DHowett
approved these changes
Jan 29, 2024
lhecker
added a commit
that referenced
this pull request
Jan 30, 2024
conhost has 2 bugs related to clipboard handling: * Missing retry on `OpenClipboard`: When copying to the clipboard explorer.exe is very eager to open the clipboard and peek into it. I'm not sure why it happens, but I can see `CFSDropTarget` in the call stack. It uses COM RPC and so this takes ~20ms every time. That breaks conhost's clipboard randomly during `ConsoleBench`. During non-benchmarks I expect this to break during RDP. * Missing null-terminator check during paste: `CF_UNICODETEXT` is documented to be a null-terminated string, which conhost v2 failed to handle as it relied entirely on `GlobalSize`. Additionally, this changeset simplifies the `HGLOBAL` code slightly by adding `_copyToClipboard` to abstract it away. * `ConsoleBench` (#16453) doesn't fail randomly anymore ✅ (cherry picked from commit 86c30bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conhost has 2 bugs related to clipboard handling:
OpenClipboard: When copying to the clipboardexplorer.exe is very eager to open the clipboard and peek into it.
I'm not sure why it happens, but I can see
CFSDropTargetin thecall stack. It uses COM RPC and so this takes ~20ms every time.
That breaks conhost's clipboard randomly during
ConsoleBench.During non-benchmarks I expect this to break during RDP.
CF_UNICODETEXTisdocumented to be a null-terminated string, which conhost v2
failed to handle as it relied entirely on
GlobalSize.Additionally, this changeset simplifies the
HGLOBALcode slightlyby adding
_copyToClipboardto abstract it away.Validation Steps Performed
ConsoleBench(Add an automated conhost benchmark tool #16453) doesn't fail randomly anymore ✅