Fix parsing of chunked win32-input-mode sequences #16466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
DHowett
approved these changes
Dec 13, 2023
DHowett
reviewed
Dec 13, 2023
Co-authored-by: Dustin L. Howett <[email protected]>
DHowett
approved these changes
Dec 13, 2023
PankajBhojwani
approved these changes
Dec 15, 2023
DHowett
reviewed
Dec 15, 2023
DHowett
approved these changes
Dec 15, 2023
DHowett
approved these changes
Dec 15, 2023
DHowett
pushed a commit
that referenced
this pull request
Dec 15, 2023
Even with the previous fixes we still randomly encounter win32- input-mode sequences that are broken up in exactly such a way that e.g. lone escape keys are encounters. Those for instance clear the current prompt. The remaining parts of the sequence are then visible. This changeset fixes the issue by skipping the entire force-to-ground code whenever we saw at least 1 win32-input-mode sequence. Related to #16343 ## Validation Steps Performed * Host a ConPTY inside ConPTY (= double the trouble) with cmd.exe * Paste random amounts of text * In the old code spurious `[..._` strings are seen * In the new code they're consistently gone ✅ (cherry picked from commit bc18348) Service-Card-Id: 91337332 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with the previous fixes we still randomly encounter win32-
input-mode sequences that are broken up in exactly such a way that
e.g. lone escape keys are encounters. Those for instance clear the
current prompt. The remaining parts of the sequence are then visible.
This changeset fixes the issue by skipping the entire force-to-ground
code whenever we saw at least 1 win32-input-mode sequence.
Related to #16343
Validation Steps Performed
[..._strings are seen