Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover telemetry code #16468

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Remove leftover telemetry code #16468

merged 3 commits into from
Jan 9, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Dec 13, 2023

This cleans up some leftover unused telemetry skeleton code.

Validation Steps Performed

  • A TraceLogging viewing application shows events ✅

@lhecker lhecker added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Dec 13, 2023
@lhecker lhecker changed the title Add missing TraceLoggingRegister calls Remove leftover telemetry code Dec 13, 2023
Base automatically changed from dev/lhecker/register-tracing to main December 15, 2023 23:29
@lhecker lhecker marked this pull request as ready for review January 9, 2024 20:31
@DHowett DHowett enabled auto-merge (squash) January 9, 2024 20:44
@DHowett DHowett merged commit fb8b120 into main Jan 9, 2024
18 of 20 checks passed
@DHowett DHowett deleted the dev/lhecker/more-telemetry-cleanups branch January 9, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhecker @carlos-zamora @zadjii-msft @DHowett