Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable alternate scroll mode by default #16535

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Enable alternate scroll mode by default #16535

merged 1 commit into from
Jan 9, 2024

Conversation

j4james
Copy link
Collaborator

@j4james j4james commented Jan 7, 2024 •
edited
Loading

Summary of the Pull Request

This PR enables alternate scroll mode by default, and also fixes the
precedence so if there is any other mouse tracking mode enabled, that
will take priority.

Validation Steps Performed

I've manually tested by viewing a file with less, and confirmed that
it can now scroll using the mouse wheel by default. Also tested mouse
mouse in vim and confirmed that still works.

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Task It's a feature request, but it doesn't really need a major design. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-VT Virtual Terminal sequence support Product-Terminal The new Windows Terminal. labels Jan 7, 2024
@j4james j4james marked this pull request as ready for review January 7, 2024 11:15
DHowett
DHowett approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! It's such a gift to come back to so many PRs from you 😄

@DHowett DHowett enabled auto-merge (squash) January 8, 2024 16:21
zadjii-msft
zadjii-msft approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a happy new year, thanks!

@DHowett DHowett merged commit d115500 into microsoft:main Jan 9, 2024
15 checks passed
@j4james j4james deleted the fix-altscroll-default branch February 10, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-VT Virtual Terminal sequence support Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable alternate scroll mode by default
3 participants
@j4james @DHowett @zadjii-msft