Add support for turning off full-color Emoji #16871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
lhecker
approved these changes
Mar 13, 2024
src/renderer/atlas/BackendD3D.cpp
Outdated
| @@ -1316,7 +1316,12 @@ BackendD3D::AtlasGlyphEntry* BackendD3D::_drawGlyph(const RenderingPayload& p, c | |||
| }); | |||
|
|
|||
| { | |||
| const auto enumerator = TranslateColorGlyphRun(p.dwriteFactory4.get(), {}, &glyphRun); | |||
| wil::com_ptr<IDWriteColorGlyphRunEnumerator1> enumerator{ nullptr }; | |||
There was a problem hiding this comment.
nit: No need to write out { nullptr } explicitly.
|
|
zadjii-msft
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for disabling full-color emoji (and technically other COLR-related font features!)
Full-color emoji don't respond to SGR colors, intensity, faint or blink. Some users also just prefer the line art ones.
Related to #15979
Refs #1790
Closes #956