Prevent multiple settings tabs from being persisted #17169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
May 1, 2024
To be fair, we legitimately did want to prevent this. We didn't widen the scope of non-terminal panes to include "you can open a settings anyway" for 1.21... |
DHowett
approved these changes
May 1, 2024
carlos-zamora
approved these changes
May 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add some machinery to special case settings tabs. When we're going to persist a tab that only has a single settings pane in it, we'll now promote that to the first-class "openSettings" action. This will allow our other code in TerminalPage to route multiple settings tabs all to the same tab.
This of course doesn't stop you from opening multiple settings tabs with
{ "command": {"action": "newTab", "type": "settings"} }actions. If we did that, then that would prevent someone from having a settings pane in the first pane, and a terminal to the right.Closes #17070