Fix inaccurate Solarized palette

[antoineco]

Summary of the Pull Request

Some of the colors from the Solarized schemes that ship with Windows Terminal are not aligned with the reference Solarized palette.

References

Also requires #293 for correct rendering of background/foreground colors.

PR Checklist

• Closes Solarized schemes shipped in Terminal Preview are incorrect #1509
• CLA signed.
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Detailed Description of the Pull Request / Additional comments

Implements the changes discussed in #1509 (comment).

Validation Steps Performed

No behavioral changes.

[zadjii-msft]

Seems reasonable to me

[DHowett-MSFT]

Seems reasonable to me.

[DHowett-MSFT]

Thanks!

[bigstevebennett]

Hi, when I select Solarized dark for powershell core (7 RC2) I lose some command syntax highlights and command switches use a colour that is not distinguishable against the background. Is this a related issue or just a bad match of scheme - colour palette entries for the PS core highlighting scheme?

Thanks for your work on this BTW !

Edit: I alleviated the issue by modding the solarized dark definition slightly - (the brightblack and background has the same colour in my version and bright yellow is more of a grey-blue colour)
"brightBlack": "#5c6a6b",
"brightYellow": "#F9F1A5"

[antoineco]

@bigstevebennett the original Solarized scheme may not work the best on Windows because ConPTY doesn't render "black background" and "white foreground" properly (#293 (comment)). @DHowett-MSFT mentioned this was fixable, but not enabled by default due to backward compatibility. Until a solution is provided, I believe you have to tune your syntax highlighting accordingly.