-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inaccurate Solarized palette #1720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
Thanks! |
(cherry picked from commit 078e642)
(cherry picked from commit 078e642)
Hi, when I select Solarized dark for powershell core (7 RC2) I lose some command syntax highlights and command switches use a colour that is not distinguishable against the background. Is this a related issue or just a bad match of scheme - colour palette entries for the PS core highlighting scheme? Thanks for your work on this BTW ! Edit: I alleviated the issue by modding the solarized dark definition slightly - (the brightblack and background has the same colour in my version and bright yellow is more of a grey-blue colour) |
@bigstevebennett the original Solarized scheme may not work the best on Windows because ConPTY doesn't render "black background" and "white foreground" properly (#293 (comment)). @DHowett-MSFT mentioned this was fixable, but not enabled by default due to backward compatibility. Until a solution is provided, I believe you have to tune your syntax highlighting accordingly. |
Summary of the Pull Request
Some of the colors from the Solarized schemes that ship with Windows Terminal are not aligned with the reference Solarized palette.
References
Also requires #293 for correct rendering of background/foreground colors.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Implements the changes discussed in #1509 (comment).
Validation Steps Performed
No behavioral changes.