Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the animations from the suggestions UI #17247

Merged
merged 5 commits into from
May 13, 2024

Conversation

zadjii-msft
Copy link
Member

gotta go fast, and these animations are not fast

noted in #15845

Remove all item animations from the suggestions UI. They're
entirely too slow to let that UI be usable.
-->
<Style x:Key="NoAnimationsPls"

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[Pls](#security-tab) is not a recognized word. \(unrecognized-spelling\)
@@ -203,7 +222,10 @@
ItemClick="_listItemClicked"
ItemsSource="{x:Bind FilteredActions}"
SelectionChanged="_listItemSelectionChanged"
SelectionMode="Single" />
SelectionMode="Single"
Style="{StaticResource NoAnimationsPls}">

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[Pls](#security-tab) is not a recognized word. \(unrecognized-spelling\)
src/cascadia/TerminalApp/SuggestionsControl.xaml Outdated Show resolved Hide resolved
@@ -12,6 +12,7 @@
xmlns:model="using:Microsoft.Terminal.Settings.Model"
xmlns:mtu="using:Microsoft.Terminal.UI"
xmlns:mux="using:Microsoft.UI.Xaml.Controls"
MinWidth="256"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be this much, or can we let the width get adjusted dynamically as a percentage of the page width? Do we need a MaxWidth?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that was an unrelated nit that snuck in accidentally. IMO this makes it feel a lot smoother, since the width doesn't snap back and forth. The placeholder text makes the menu open at like, 252px or something, but then filtering the menu usually immediately makes it quite a bit narrower. This keeps the width a bit more consistent

@zadjii-msft
Copy link
Member Author

before

after

117b7517-196b-4bab-97cb-e1b9b76580f8

sxnui-no-animations

@zadjii-msft zadjii-msft added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 46526bc May 13, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/f/remove-sxnui-animations branch May 13, 2024 17:17
DHowett pushed a commit that referenced this pull request May 13, 2024
gotta go fast, and these animations are not fast

noted in #15845

(cherry picked from commit 46526bc)
Service-Card-Id: 92546875
Service-Version: 1.21
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
Exactly the same as #17247, but also just applied to the command
palette. It's so much better guys.
@zadjii-msft zadjii-msft added this to the Terminal v1.22 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants