Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor coordinates are viewport-relative #17332

Merged
merged 1 commit into from
May 29, 2024
Merged

Cursor coordinates are viewport-relative #17332

merged 1 commit into from
May 29, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented May 29, 2024

The changeset is rather self-explanatory.
Some things in the rendering code are in
absolute and some things are in relative
coordinates. Cursor coordinates belong to
the latter. It's a bit confusing.

Closes #17310

Validation Steps Performed

  • Use the GDI text renderer
  • Use cmd
  • Press and hold Enter
  • No more ghostly cursors ✅

@zadjii-msft zadjii-msft added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 0bd0eea May 29, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/lhecker/17310-cursor-invalidation branch May 29, 2024 18:09
@lhecker lhecker mentioned this pull request Jul 25, 2024
Merged
lhecker added a commit that referenced this pull request Jul 26, 2024
@lhecker
Fix cursor invalidation, again (#17617)
295cd17 
Regressed in #15500, incorrectly fixed in #17332, exposed by #17583.
My ineptitude on full display. If this isn't the last cursor
invalidation bug I'm going to cry.

Closes #17615

## Validation Steps Performed
* cmd.exe
* a directory with 6 files
* 80x24 viewport
* run `cls`
* run `dir` twice
@lhecker lhecker added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@zadjii zadjii zadjii approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ghostly cursor droppings in OpenConsole
4 participants
@lhecker @DHowett @zadjii @zadjii-msft