Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious clear-to-end sequence in buffer dumps #17374

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix spurious clear-to-end sequence in buffer dumps #17374

merged 1 commit into from
Jun 5, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jun 5, 2024

I think I forgot to complete that section of the code...
The parentheses were missing and beg was repeated twice. The last
line in the comment above this explains what I intended it to be.

Closes #17365

Validation Steps Performed

  • In a new PowerShell tab
  • Run "`e[999C`e[2D`e[42mfoo`e[m"
  • Newline until it scrolls
  • Run it again
  • Close and reopen
  • The green "foo" is still green ✅

@lhecker lhecker enabled auto-merge June 5, 2024 19:11
@lhecker lhecker added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 640424e Jun 5, 2024
20 checks passed
@lhecker lhecker deleted the dev/lhecker/17365-buffer-clear branch June 5, 2024 19:54
DHowett pushed a commit that referenced this pull request Jun 7, 2024
@lhecker @DHowett
Fix spurious clear-to-end sequence in buffer dumps (#17374)
334335f 
I think I forgot to complete that section of the code...
The parentheses were missing and `beg` was repeated twice. The last
line in the comment above this explains what I intended it to be.

Closes #17365

## Validation Steps Performed
* In a new PowerShell tab
* Run ``"`e[999C`e[2D`e[42mfoo`e[m"``
* Newline until it scrolls
* Run it again
* Close and reopen
* The green "foo" is still green ✅

(cherry picked from commit 640424e)
Service-Card-Id: 92687334
Service-Version: 1.21
@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
1.21 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.22 Session restoration emits a [K even at the end of the line, deleting last character
3 participants
@lhecker @DHowett @zadjii-msft