Modernize VtPipeTerm #17647
Merged
Modernize VtPipeTerm #17647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| BOOL WINAPI ReadConsoleInputExA( | ||
| _In_ HANDLE hConsoleInput, | ||
| _Out_writes_(nLength) PINPUT_RECORD lpBuffer, |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
This comment has been minimized.
This comment has been minimized.
DHowett
approved these changes
Aug 2, 2024
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClCompile Include="main.cpp" /> | ||
| <ClCompile Include="VtConsole.cpp" /> |
There was a problem hiding this comment.
if i recall, this builds in Windows too. Can you update sources?
| unsigned short width = srViewport.Right - srViewport.Left + 1; | ||
| unsigned short height = srViewport.Bottom - srViewport.Top + 1; | ||
| HPCON hPC = nullptr; | ||
| THROW_IF_FAILED(ConptyCreatePseudoConsole(viewportSize, pipe.client.get(), pipe.client.get(), 0, &hPC)); |
DHowett
reviewed
Aug 2, 2024
| @@ -1,16 +0,0 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
There was a problem hiding this comment.
Oh, I forgot about this comment.
I initially thought this was a leftover file for translatable strings, but now I realize that this is for the .exe information. Hmmm, I think it's fine to remove in that case, since despite this tool being part of the OS repo, I'm not sure it's used by anyone there anyway.
DHowett
approved these changes
Aug 5, 2024
DHowett
approved these changes
Aug 12, 2024
zadjii-msft
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shortens VtPipeTerm quite a bit, which used to have various debug
flags and modes. I kept the
--outflag to redirect the output to afile, but I removed the
--debug(pipe the output through WSL andshow escape sequences visually) and
--headless(hide conpty) flags.I did this, because VtPipeTerm always used the system ConPTY API
but I needed it to use my local OpenConsole. I also wanted it to
use overlapped IO for testing but found that it was too difficult
to refactor make that work.
I also noticed that the project was the only holdout for
conpty.hwhich had to be kept in sync withwinconpty.h.