Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log action dispatch occurrence #17718

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Log action dispatch occurrence #17718

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46d5fcc
Log action dispatch occurrence
carlos-zamora Aug 15, 2024
ff4852a
simplify!
carlos-zamora Aug 20, 2024
2914181
string_views are hard
carlos-zamora Aug 20, 2024
d49f4bc
simplify
carlos-zamora Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/cascadia/TerminalApp/ShortcutActionDispatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,20 @@ namespace winrt::TerminalApp::implementation
default:
return false;
}
return eventArgs.Handled();
const auto handled = eventArgs.Handled();

if (handled)
{
TraceLoggingWrite(
g_hTerminalAppProvider,
"ActionDispatched",
TraceLoggingDescription("Event emitted when an action was successfully performed"),
TraceLoggingValue(static_cast<int>(actionAndArgs.Action()), "Action"),
TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES),
TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage));
}

return handled;
}

bool ShortcutActionDispatch::DoAction(const ActionAndArgs& actionAndArgs)
Expand Down
Loading