-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for querying Xterm dynamic colors and palette #17729
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
86286e4
Replace OSC Set{Default,Foreground,Cursor} with a mapping table
DHowett b5fd8f3
Add support for querying the color values of OSC 10, 11 and 12.
DHowett d53b1b4
Add support for reporting colors via OSC 4
DHowett 99d1979
Flush OSC through InputStateMachineEngine for inquiries over conpty
DHowett 19c301e
Dispense with the XtermColorResource enumeration
DHowett 0fe2b89
It's fine for AdaptDispatch to except
DHowett da99629
Add another adapter test for INVALID_COLOR reporting
DHowett 9d371d0
Add an output engine test for Xterm reporting
DHowett 88bc529
Add an adapter test for OSC 4 reporting
DHowett fafe99f
Add an output engine test for OSC 4 reporting
DHowett 250a924
Fix the VT names in the comments
DHowett 594e6bd
Teach the spellbot to ignore rgb:xxxx/yyyy/zzzzs
DHowett 3e714d9
Streamline GetOscSetColor and +Table
DHowett e5e0e83
Teach the spellbot to *actually* ignore rgb:xxxx/yyyy/zzzzs
DHowett f00c142
Pass audit mode - OscDispatch cannot be noexcept
DHowett 43e8883
Pass through all OSCs always(?)
DHowett df6b466
Merge remote-tracking branch 'origin/main' into dev/duhowett/osc-xter…
DHowett 10c97a9
Update src/terminal/adapter/adaptDispatch.cpp
DHowett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not be filling all of these in, but are technically part of Xterm's supported color complement. We could put TEKTRONIX colors in here if we ever support it (OSC 15, 16, 18). We may never support pointer colors (OSC 13, 14). I intend to support selection colors (OSC 17, 19).