Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't NCPAINT our window, PAINT our window #1898

Merged
merged 7 commits into from
Jul 12, 2019

Commits on Jul 9, 2019

  1. This definitely works for getting shadow, pointy corners back

      Don't do anything in NCPAINT. If you do, you have to do everything. But the
      whole point of DwmExtendFrameIntoClientArea is to let you paint the NC area in
      your normal paint. So just do that dummy.
    
      * This doesn't transition across monitors.
      * This has a window style change I think is wrong.
      * I'm not sure the margins change is important.
    zadjii-msft committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    15a1f48 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bc9969 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf239b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    22e1023 View commit details
    Browse the repository at this point in the history
  5. heyo this works.

      I'm not entirely sure why. But if we only update the titlebar drag region when
      that actually changes, it's a _lot_ smoother. I'm not super happy with the
      duplicated work in _UpdateDragRegion and OnSize, but checking this in in case
      I can't figure that out.
    zadjii-msft committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    aad9f56 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5fd4191 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Configuration menu
    Copy the full SHA
    9040940 View commit details
    Browse the repository at this point in the history