-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide the CloseWindow warning experience for the 'X' button #3049
Provide the CloseWindow warning experience for the 'X' button #3049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm fine with this.
please make sure your pull request names are reasonable ("dev/kawa/1589 do the thing" is not a great branch name) Pretend that they are completing the sentence, "This pull request will ..." |
PR name changed. I wonder if I need to change the branch name ? This may require to post a new PR. |
No, you can keep the branch name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 Handy links: |
This is a follow up project of #1589 , which warns users of multiple tabs opened when press ALT+F4.
Now we are going to connect this experience with the 'X' button of the window.
For now, this PR only includes the implementation for IslandWindow (client window). Non-client window experience is still under implementation.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
To Test: