Updated TitleBar Buttons to be consistent with other Windows ap… #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the color of the Close Button on mouse hover from Red to "#e81123" which is the color used by other uwp apps.
Changed the button width to be consistent with other uwp apps.
DHowett-MSFT
approved these changes
Nov 30, 2019
ghost
requested review from
zadjii-msft
changed the title
zadjii-msft
added
Area-User Interface
DHowett-MSFT
pushed a commit
that referenced
this pull request
Dec 2, 2019
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR updates the TitleBar buttons to be more consistent with other Windows apps. Current buttons are a tiny bit smaller as compared to Chrome/Credge/Settings:  <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] CLA signed * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments This PR changes the PointerHover Background of the close button on the TitleBar to match other Windows apps, from "#ff0000" to "#e81123". Also, the button width has been changed to 46 to be the same as other windows apps. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ------------------------------------------ * Fix Close Button Color Changed the color of the Close Button on mouse hover from Red to "#e81123" which is the color used by other uwp apps. * Updated Button Width Changed the button width to be consistent with other uwp apps. (cherry picked from commit 7719f8f)
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR updates the TitleBar buttons to be more consistent with other Windows apps.
Current buttons are a tiny bit smaller as compared to Chrome/Credge/Settings:
PR Checklist
Detailed Description of the Pull Request / Additional comments
This PR changes the PointerHover Background of the close button on the TitleBar to match other Windows apps, from "#ff0000" to "#e81123". Also, the button width has been changed to 46 to be the same as other windows apps.