Fixed throwing floating point cast #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
Nov 30, 2019
ghost
requested review from
zadjii-msft
reviewed
Dec 2, 2019
zadjii-msft
approved these changes
Dec 2, 2019
zadjii-msft
added
Area-TerminalControl
DHowett-MSFT
pushed a commit
that referenced
this pull request
Dec 2, 2019
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Replaced a `gsl::narrow` call to `gsl::narrow_cast` call. The `gsl::narrow` call used to throw when the user had custom display scaling due to a bad comparison between floating point values. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References Possible other [startup crashes](#3749 (comment)). I'll update this as they're found. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3749, likely #3747 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3749 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments It's a one line fix. If you want more context, here's the [full description](#3749 (comment)) of the problem. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Set my machine to a custom scaling and opened a fixed build of the WT. My WT started up without crashing and continued to operate without issues (including maximizing, minimizing, and fullscreen toggle). (cherry picked from commit b17038b)
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Replaced a
gsl::narrowcall togsl::narrow_castcall. Thegsl::narrowcall used to throw when the user had custom display scaling due to a bad comparison between floating point values.References
Possible other startup crashes. I'll update this as they're found.
PR Checklist
Detailed Description of the Pull Request / Additional comments
It's a one line fix. If you want more context, here's the full description of the problem.
Validation Steps Performed
Set my machine to a custom scaling and opened a fixed build of the WT. My WT started up without crashing and continued to operate without issues (including maximizing, minimizing, and fullscreen toggle).