Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DxEngine drawing ETW tracing for debugging and diagnostics purposes #4664

Merged
6 commits merged into from
Feb 20, 2020

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Feb 20, 2020

Summary of the Pull Request

Adds an ETW provider for tracing out operations inside the DirectX Renderer.

References

This supports #2191 and #778 and other rendering issues.

PR Checklist

  • I work here

Detailed Description of the Pull Request / Additional comments

This declares and defines the provider with the a GUID appropriate for the namespace and adds an initial invalidation rectangle method for figuring out what is being drawn mostly to understand what could be differential.

Validation Steps Performed

Implemented provider.
Opened real-time ETW tracing tool
Ran the Terminal and watched invalidation events appear live

@miniksa miniksa added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Feb 20, 2020
@miniksa miniksa self-assigned this Feb 20, 2020
src/renderer/dx/DxRenderer.cpp Show resolved Hide resolved
@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Feb 20, 2020
@ghost
Copy link

ghost commented Feb 20, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 50 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member Author

miniksa commented Feb 20, 2020

@msftbot wait 1 minute

@ghost
Copy link

ghost commented Feb 20, 2020

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 20 Feb 2020 21:48:08 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 215df32 into master Feb 20, 2020
@ghost ghost deleted the dev/miniksa/drawtel branch February 20, 2020 23:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants