-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ctrl+# keys #4938
Conversation
@msftbot merge this in 1 minute |
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
(The test itself seems to be failing?) |
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
## Summary of the Pull Request Fixes the <kbd>Ctrl+Num</kbd> keys in both conhost and the Terminal. These keys are supposed to be mapped to specific characters according to [this doc](https://vt100.net/docs/vt220-rm/table3-5.html). Now we actually handle them correctly. ## PR Checklist * [x] Closes #3507 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * Ran test * tested in `gnome-terminal` with `showkeys -a` * tested in conhost with `showkeys -a` * tested in Windows Terminal with `showkeys -a` (cherry picked from commit f7d106d)
@zadjii-msft Does this also send the same codes when Shift is held? Some applications--e.g., mosh--advise users to press a combination such as Ctrl + ^ to send |
🎉 Handy links: |
Summary of the Pull Request
Fixes the Ctrl+Num keys in both conhost and the Terminal. These keys are supposed to be mapped to specific characters according to this doc. Now we actually handle them correctly.
PR Checklist
Validation Steps Performed
gnome-terminal
withshowkeys -a
showkeys -a
showkeys -a