Use an Automatic split for splitPane by default #5194
Conversation
|
Now that the "split" keybinding arg assumes the value of "auto", should we make it no longer required? If so, we should update SettingsSchema.md and profiles.schema.json |
Actually, this is where the timeline can get a little messy too. It's small, but editing the schema before publishing these changes to the store means that they're out of sync. :/ so I'll just approve for now since I don't know what the correct course of action is. We should update them at some point though. Tagging @cinnamon-msft to make sure these changes are reflected in the docs. |
| Log::Result(WEX::Logging::TestResults::Skipped); | ||
| return; | ||
|
|
||
| // // * Create a tab with a profile with GUID 1 |
There was a problem hiding this comment.
Broadly I’d prefer an #if 0 block because it doesn’t delta every single line, but.. idc enough to block for it
| { | ||
| if (_splitHorizontal) | ||
| { | ||
| args->SplitStyle(SplitState::Horizontal); | ||
| } | ||
| else if (_splitVertical) | ||
| { | ||
| args->SplitStyle(SplitState::Horizontal); | ||
| args->SplitStyle(SplitState::Vertical); |
There was a problem hiding this comment.
wait did we ship with -V meaning Horizontal
|
Before this goes in, would you mind removing line 233 of the JSON schema? It states that |
|
@cinnamon-msft I think that’s what Carlos was asking for your input on, because of the lag time between a feature landing here and it being part of the official schema for all users on all versions. |
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in 8 minutes |
|
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
|
🎉 Handy links: |
Summary of the Pull Request
You no longer need to specify the
splitargument tosplitPane, it will default toAutomaticinstead ofNonePR Checklist
Detailed Description of the Pull Request / Additional comments
Also disables the tests that are broken in #5169 while I investigate