WIP: Draw backgrounds separately from foregrounds #6224
Conversation
| (void)target; | ||
| (void)it; | ||
| (void)pEngine; | ||
| #if 0 |
There was a problem hiding this comment.
these, and their guarded regions, wil be deleted
| (!checkForeground && _background == other._background)); | ||
| } | ||
|
|
||
| // This returns whether this attribute, if printed directly next to another attribute, for the space |
There was a problem hiding this comment.
wrong. need to resurrect this tho
|
This will be cut deep by the 2661 fix., |
| @@ -104,6 +104,53 @@ Renderer::~Renderer() | |||
| return S_OK; | |||
| } | |||
|
|
|||
| template<> | |||
| struct fmt::formatter<TextColor> | |||
There was a problem hiding this comment.
don't need these to be in a this place, but we could move them into their appropriate headers later
i'd probably just delete em
|
Merge in work from the #803 bugfix -- also, maybe we should generalize BackgroundRun to RenderableAttributeRun! This would let us katamari together runs line drawing characters and break them only when they change. We want to consider how this interacts with underline (part of foreground). |
|
reopening and assigning to myself, I might need this for perf. |
|
Don't need to keep open, will post branch name in issue |
This implements #6193. It's a WIP.
Summary of the Pull Request
Alright, I've got this down to a single function that takes each dirty region and produces...
I don't like the number of vectors here, but... we're saving money by invalidating narrowly whenever possible.
Right now, because of some minor issues (#2661), backgrounds are attributes and actual final colors. It's not pleasant!
To fix:
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed