Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for running a wt commandline in the curent window WITH A KEYBINDING #6537

Merged
24 commits merged into from
Jul 17, 2020
Merged

Add support for running a wt commandline in the curent window WITH A KEYBINDING #6537

24 commits merged into from
Jul 17, 2020

Commits on Jun 16, 2020

  1. git cherry-pick 2cf6933

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    a0f5935 View commit details
    Browse the repository at this point in the history

  2. Whoop, this works for parsing a single command! This code's horribly … 

    …dirty, but _it works_
    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    3fa4687 View commit details
    Browse the repository at this point in the history

  3. do it with multiple args

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    beec8d0 View commit details
    Browse the repository at this point in the history

  4. Cleanup for review

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    349a0e6 View commit details
    Browse the repository at this point in the history

  5. split-pane ; split-pane at runtime doesn't work, pt1 

      I thought maybe breaking up the dispatcher calls would just magic fix this for me. It doesn't.
    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    fa5ecdf View commit details
    Browse the repository at this point in the history

  6. split-pane ; split-pane at runtime doesn't work, pt2 

      This does work to split multiple panes at runtime. It definitely crashes
  when the panes get too small, we might be able to adapt Pane::CanSplit to
  be smart about when it's children don't quite have a size yet.
    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    0622233 View commit details
    Browse the repository at this point in the history

  7. This works but it's dirty

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    2221764 View commit details
    Browse the repository at this point in the history

  8. A bunch of cleanup for review

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    030a91a View commit details
    Browse the repository at this point in the history

  9. more polish for review

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    c5613b5 View commit details
    Browse the repository at this point in the history

  10. add tests

    @zadjii-msft
    zadjii-msft committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    e1eef62 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/f/execut… 

    …e-order-66

# Conflicts:
#	src/cascadia/TerminalApp/ActionAndArgs.cpp
#	src/cascadia/TerminalApp/ActionArgs.cpp
#	src/cascadia/TerminalApp/ActionArgs.h
#	src/cascadia/TerminalApp/ActionArgs.idl
#	src/cascadia/TerminalApp/AppActionHandlers.cpp
#	src/cascadia/TerminalApp/ShortcutActionDispatch.cpp
#	src/cascadia/TerminalApp/ShortcutActionDispatch.h
#	src/cascadia/TerminalApp/ShortcutActionDispatch.idl
#	src/cascadia/TerminalApp/TerminalPage.cpp
#	src/cascadia/TerminalApp/TerminalPage.h
#	src/cascadia/TerminalApp/lib/pch.h
    @zadjii-msft
    zadjii-msft committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    47d5232 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/f/execut… 

    …e-order-66

# Conflicts:
#	src/cascadia/TerminalControl/TermControl.cpp
    @zadjii-msft
    zadjii-msft committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fedfafa View commit details
    Browse the repository at this point in the history

  2. nits from PR

    @zadjii-msft
    zadjii-msft committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a4c78cd View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Don't open a new process when the cmdline is empty

    @zadjii-msft
    zadjii-msft committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    15f22c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Merge remote-tracking branch 'origin/master' into dev/migrie/f/execut… 

    …e-order-66
    @zadjii-msft
    zadjii-msft committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    b56ea18 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dev/migrie/f/execut… 

    …e-order-66

# Conflicts:
#	src/cascadia/TerminalApp/AppLogic.idl
#	src/cascadia/TerminalApp/ShortcutActionDispatch.idl
    @zadjii-msft
    zadjii-msft committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    87f7c79 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Merge branch 'dev/migrie/f/execute-order-66' of https://github.com/Mi… 

    …crosoft/Terminal into dev/migrie/f/execute-order-66
    @zadjii-msft
    zadjii-msft committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    c290eb8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dev/migrie/f/execut… 

    …e-order-66
    @zadjii-msft
    zadjii-msft committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    a60b68f View commit details
    Browse the repository at this point in the history

  3. We should, perhaps, return a warning when there's no commandline

    @zadjii-msft
    zadjii-msft committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    6a0a270 View commit details
    Browse the repository at this point in the history

  4. Remove this change from earlier prototyping. It sure _wasn't_ necessary

    @zadjii-msft
    zadjii-msft committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    d57a5cc View commit details
    Browse the repository at this point in the history

  5. don't re-use _startupActions, pass a collection in

    @zadjii-msft
    zadjii-msft committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    96f4015 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Update src/cascadia/TerminalApp/GlobalAppSettings.cpp

    @zadjii-msft
    zadjii-msft authored Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6eda0fe View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dev/migrie/f/execut… 

    …e-order-66
    @zadjii-msft
    zadjii-msft committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    dda58f9 View commit details
    Browse the repository at this point in the history

  3. Use the new jsonutils

    @zadjii-msft
    zadjii-msft committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6417fa9 View commit details
    Browse the repository at this point in the history