Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copying the bitmap on the way into the tracing function #6839

Merged
1 commit merged into from
Jul 8, 2020
Merged

Avoid copying the bitmap on the way into the tracing function #6839

1 commit merged into from
Jul 8, 2020

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Jul 8, 2020

PR Checklist

  • Closes perf itch.
  • I work here.
  • Manual perf test.
  • Documentation irrelevant.
  • Schema irrelevant.
  • Am core contributor.

Detailed Description of the Pull Request / Additional comments

Passes the bitmap by ref into the tracing function instead of making a copy on the way in. It's only read anyway for tracing (if enabled) so the copy was a pointless oversight.

Validation Steps Performed

  • Observed WPR trace before and after with time cat big.txt in WSL.

@miniksa miniksa added Product-Conhost For issues in the Console codebase Area-Performance Performance-related issue Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 8, 2020
@miniksa miniksa self-assigned this Jul 8, 2020
@miniksa
Copy link
Member Author

miniksa commented Jul 8, 2020

Before:
before bitmap copy into trace

After:
after bitmap copy into trace

@DHowett
Copy link
Member

DHowett commented Jul 8, 2020

Nit: please reword title to be in imperative mood and as though it completes the sentence "This commit will..."

@miniksa miniksa changed the title Does not copy the bitmap on the way into the tracing function Avoid copying the bitmap on the way into the tracing function Jul 8, 2020
@DHowett
Copy link
Member

DHowett commented Jul 8, 2020

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 8, 2020
@ghost
Copy link

ghost commented Jul 8, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 08 Jul 2020 22:10:55 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 99c33e0 into master Jul 8, 2020
@ghost ghost deleted the dev/miniksa/perf_bitmap_copy branch July 8, 2020 22:13
DHowett pushed a commit that referenced this pull request Jul 17, 2020
@miniksa @DHowett
Avoid copying the bitmap on the way into the tracing function (#6839)
6b0b6be 
## PR Checklist
* [x] Closes perf itch.
* [x] I work here.
* [x] Manual perf test.
* [x] Documentation irrelevant.
* [x] Schema irrelevant.
* [x] Am core contributor.

## Detailed Description of the Pull Request / Additional comments
Passes the bitmap by ref into the tracing function instead of making a copy on the way in. It's only read anyway for tracing (if enabled) so the copy was a pointless oversight.

## Validation Steps Performed
- Observed WPR trace before and after with `time cat big.txt` in WSL.

(cherry picked from commit 99c33e0)
@ghost
Copy link

ghost commented Jul 21, 2020

🎉Windows Terminal v1.1.2021.0 has been released which incorporates this pull request.:tada:

Handy links:

1 similar comment
@ghost
Copy link

ghost commented Jul 22, 2020

🎉Windows Terminal v1.1.2021.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 22, 2020

🎉Windows Terminal Preview v1.2.2022.0 has been released which incorporates this pull request.:tada:

Handy links:

@miniksa miniksa mentioned this pull request Dec 10, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

@miniksa miniksa

Labels
Area-Performance Performance-related issue AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniksa @DHowett @zadjii-msft