Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and ship an actual binary named wt that just launches WT #6860

Merged
2 commits merged into from
Jul 10, 2020
Merged

Build and ship an actual binary named wt that just launches WT #6860

2 commits merged into from
Jul 10, 2020
+200 −3

Commits on Jul 10, 2020

  1. Build and ship an actual binary named wt/wtd that just launches WT 

    Due to a shell limitation, Ctrl+Shift+Enter will not launch Windows
Terminal as Administrator. This is caused by the app execution alias and
the actual targeted executable not having the same name.

In addition, PowerShell has an issue detecting app execution aliases as
GUI/TUI applications. When you run wt from PowerShell, the shell will
wait for WT to exit before returning to the prompt. Having a shim that
immediately re-executes WindowsTerminal and then returns handily knocks
this issue out (as the process that PS was waiting for exits
immediately.)

This could cause a regression for anybody who tries to capture the PID
of wt.exe. Our process tree is not an API, and we have offered no
consistency guarantee on it.

Fixes #4645 (PowerShell waits for wt)
Fixes #6625 (Can't launch as admin using C-S-enter)
    @DHowett
    DHowett committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    0fca1d3 View commit details
    Browse the repository at this point in the history

  2. shim: clean up init, commandline, give it a res file

    @DHowett
    DHowett committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    8eeef1d View commit details
    Browse the repository at this point in the history