-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix close button not using the tab's text color (#8046) #8209
Fix close button not using the tab's text color (#8046) #8209
Conversation
@zadjii-msft , @dcheatha - I guess this one is blocked on the conflict - the name of the Tab was changed to TerminalTab |
@dcheatha can you take care of the conflict? It shouldn't be too bad considering it's really just a renamed file that git can't follow 🤷♂️ |
@zadjii-msft Hi, I rebased the commit off of main. I hope that's okay! |
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This sets the tab close button color to match the tab text color. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #8046 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #8046 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #8046 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments This sets the tab close button color to match the tab text color. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Test light theme white tab mouse hover effect: ![Screenshot_2020-11-07_152110_3](https://user-images.githubusercontent.com/7143383/98640319-ec735e80-22de-11eb-8d35-08188405b566.png) Test dark theme white tab mouse hover effect: ![Screenshot_2020-11-07_153021_2](https://user-images.githubusercontent.com/7143383/98640377-f006e580-22de-11eb-9bb5-dde9fe9b81b6.png) (cherry picked from commit 2a34080)
🎉 Handy links: |
🎉 Handy links: |
Summary of the Pull Request
This sets the tab close button color to match the tab text color.
References
#8046
PR Checklist
Detailed Description of the Pull Request / Additional comments
This sets the tab close button color to match the tab text color.
Validation Steps Performed
Test light theme white tab mouse hover effect:
Test dark theme white tab mouse hover effect: