Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach flyouts and palette to prefer user bindings over defaults #8725

Merged
3 commits merged into from
Jan 12, 2021
Merged

Teach flyouts and palette to prefer user bindings over defaults #8725

3 commits merged into from
Jan 12, 2021

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Jan 8, 2021 •
edited by DHowett
Loading

Store the order of the bindings and upon lookup prefer the binding
that was added last.
The defaults will always "loose" to user overrides.

Closes #2991

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 8, 2021
@Don-Vito Don-Vito marked this pull request as draft January 8, 2021 17:14
@Don-Vito Don-Vito marked this pull request as ready for review January 8, 2021 17:56
@zadjii-msft zadjii-msft mentioned this pull request Jan 12, 2021
Open
34 tasks
zadjii-msft
zadjii-msft approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this is straightforward (or straight backward 😄). Thanks!

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Jan 12, 2021
DHowett
DHowett approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Very clever.

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 12, 2021
@ghost
Copy link

ghost commented Jan 12, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 058cbd1 into microsoft:main Jan 12, 2021
DHowett pushed a commit that referenced this pull request Jan 25, 2021
@Don-Vito @DHowett
Teach flyouts and palette to prefer user bindings over defaults (#8725)
2692874 
Store the order of the bindings and upon lookup prefer the binding
that was added last.
The defaults will always "loose" to user overrides.

Closes #2991

(cherry picked from commit 058cbd1)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal v1.5.10271.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@Don-Vito @mpela81
Teach flyouts and palette to prefer user bindings over defaults (micr…
b7296ff 
…osoft#8725)

Store the order of the bindings and upon lookup prefer the binding
that was added last.
The defaults will always "loose" to user overrides.

Closes microsoft#2991
@zadjii-msft zadjii-msft mentioned this pull request Feb 18, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User keybindings for profiles in the flyout should have priority over default keybindings
4 participants
@Don-Vito @DHowett @miniksa @zadjii-msft