Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor restore to happen on the tab row #8952

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Fix cursor restore to happen on the tab row #8952

merged 1 commit into from
Feb 5, 2021

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Jan 29, 2021 •
edited by DHowett
Loading

Closes #8918

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Jan 29, 2021 •
edited
Loading

@zadjii-msft, @DHowett - created this PR for the case there is a service release. This solves the issue for tabview but doesn't solve for MinMaxCloseControl. We can probably merge this and create a follow up issue.

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jan 29, 2021
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Feb 2, 2021

@zadjii-msft - bump.

@zadjii-msft
Copy link
Member

Sorry for the delays. Dustin's busy all week so it might not be till next Monday till this gets merged for servicing, heads up.

@zadjii-msft zadjii-msft added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Feb 3, 2021
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Feb 5, 2021

@DHowett - if you are here, please take a look (this is a one-liner).

DHowett
DHowett reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if only it was less fiddly. Thank you for doing this.

@DHowett DHowett changed the title Fix cursor restore to happen on a tab row Fix cursor restore to happen on the tab row Feb 5, 2021
@DHowett DHowett merged commit 9cb8db8 into microsoft:main Feb 5, 2021
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Feb 5, 2021
DHowett pushed a commit that referenced this pull request Feb 5, 2021
@Don-Vito @DHowett
Fix cursor restore to happen on the tab row (#8952)
cf69474 
Closes #8918

(cherry picked from commit 9cb8db8)
@zadjii-msft zadjii-msft added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Feb 8, 2021
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Feb 9, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

🎉Windows Terminal Preview v1.6.10412.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@rheh rheh rheh approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

@DHowett DHowett

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A hidden mouse cursor won't reappear when moved if over a tab
4 participants
@Don-Vito @zadjii-msft @DHowett @rheh