-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in explorer background context menu logic #8977
Conversation
use win32 explorer window to find current directory folder path link user32.lib disable vcpkg use nuget packages
Co-authored-by: Carlos Zamora <[email protected]>
Co-authored-by: Carlos Zamora <[email protected]>
New misspellings found, please review:
To accept these changes, run the following commands
✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fix a bug brought in with PR: #8638 see, #8936 #8638 * [x] Closes #8936 * [x] CLA signed * [x] Tests passed With the help from @nc-x, the issue is reproduced and fixed by this patch. CLSCTX_IN_PROCESS is not good enough for all cases to create IShellWindows interface. Put a CLSCTX_ALL fixes the issue. Another debugging warning dialogs for reusing not null com_ptr in the loop is fixed too. (This was shown in debug builds only) (cherry picked from commit e207236)
Fix a bug brought in with PR: #8638 see, #8936 #8638 * [x] Closes #8936 * [x] CLA signed * [x] Tests passed With the help from @nc-x, the issue is reproduced and fixed by this patch. CLSCTX_IN_PROCESS is not good enough for all cases to create IShellWindows interface. Put a CLSCTX_ALL fixes the issue. Another debugging warning dialogs for reusing not null com_ptr in the loop is fixed too. (This was shown in debug builds only) (cherry picked from commit e207236)
🎉 Handy links: |
🎉 Handy links: |
Fix a bug brought in with PR: #8638
see,
#8936
#8638
With the help from @nc-x, the issue is reproduced and fixed by this patch.
CLSCTX_IN_PROCESS is not good enough for all cases to create IShellWindows interface.
Put a CLSCTX_ALL fixes the issue.
Another debugging warning dialogs for reusing not null com_ptr in the loop is fixed too.
(This was shown in debug builds only)