Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5 ONLY] Remove the close submenu #9102

Merged
merged 1 commit into from
Feb 10, 2021
Merged

[1.5 ONLY] Remove the close submenu #9102

merged 1 commit into from
Feb 10, 2021

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Feb 10, 2021

There's a platform issue that causes it to crash.
Fixes #8944

@DHowett
[1.5 ONLY] Remove the close submenu
c8dea3d 
There's a platform issue that causes it to crash.
Fixes #8944.
@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news. labels Feb 10, 2021
miniksa
miniksa approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big oof. OK.

@DHowett DHowett merged commit 5fdd156 into release-1.5 Feb 10, 2021
@DHowett DHowett deleted the dev/duhowett/kjhdskjhfgdkjhgdfs branch February 10, 2021 19:28
DHowett added a commit that referenced this pull request Feb 10, 2021
@DHowett
[1.5 ONLY] Remove the close submenu (#9102)
e13d1a7 
There's a platform issue that causes it to crash.
Fixes #8944.

(cherry picked from commit 5fdd156)
@ghost
Copy link

ghost commented Feb 11, 2021

🎉Windows Terminal v1.5.10411.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Feb 11, 2021
Closed
@ghost
Copy link

ghost commented Feb 11, 2021

🎉Windows Terminal Preview v1.6.10412.0 has been released which incorporates this pull request.:tada:

Handy links:

DHowett added a commit that referenced this pull request Feb 24, 2021
@DHowett
[RELEASE ONLY] Remove the close submenu (#9102)
c951a70 
There's a platform issue that causes it to crash.
Fixes #8944.

(cherry picked from commit 5fdd156)
DHowett added a commit that referenced this pull request Apr 13, 2021
@DHowett
[RELEASE ONLY] Remove the close submenu (#9102)
6072be5 
There's a platform issue that causes it to crash.
Fixes #8944.

(cherry picked from commit 5fdd156)
(cherry picked from commit c951a70)
DHowett added a commit that referenced this pull request May 14, 2021
@DHowett
Revert "[RELEASE ONLY] Remove the close submenu (#9102)"
cb7f481 
This reverts commit c951a70.
DHowett added a commit that referenced this pull request May 14, 2021
@DHowett
Revert "[RELEASE ONLY] Remove the close submenu (#9102)"
4cee91f 
This reverts commit c951a70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DHowett @miniksa