-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not dismiss selection if the Windows keys is pressed as a key-combination #9163
Do not dismiss selection if the Windows keys is pressed as a key-combination #9163
Conversation
Get changes from main repo
microsoft#8791. Don't dismiss selection if Windows key was also pressed.
Remove trailing whitespace
Clear whitespace in empty line
Revise code for better abstraction & readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert, but besides a nit looks good to me! 😊
Probably, not as a part of this PR, we should also prevent the winkey combinations from scrolling (inside Terminal::SendKeyEvent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…ination (#9163) Aims to fix #8791. <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Prior to this PR, if the Windows key was pressed as a part of a key combination, then selection was being dismissed. For example, when a user pressed `Windows` + `Shift` + `S` keys to invoke the _Capture & Annotate_ tool. This PR adds an exception for not clearing selection when either of the two Windows keys are pressed as part of a key combination. It was tested manually by trying to reproduce the issue. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #8791 * [x ] CLA signed. * [x ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #8791 <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Build Terminal. 2. Write anything & make a selection. 3. Press `Windows`+ `Shift` + `S` keys. 4. The _Capture & Annotate_ tool appears but the selection made in step 2 isn't dismissed (doesn't disappear). (cherry picked from commit 7d37ba2)
🎉 Handy links: |
🎉 Handy links: |
Aims to fix #8791.
Summary of the Pull Request
Prior to this PR, if the Windows key was pressed as a part of a key combination, then selection was being dismissed. For example, when a user pressed
Windows
+Shift
+S
keys to invoke the Capture & Annotate tool.This PR adds an exception for not clearing selection when either of the two Windows keys are pressed as part of a key combination.
It was tested manually by trying to reproduce the issue.
PR Checklist
Validation Steps Performed
Windows
+Shift
+S
keys.